Repository navigation
Conversation
tuicr finds a saved session by the name that it gives the session, so a carried session must keep that name. The carry renamed the session to a name that only timber used, so tuicr did not find the carried session and wrote a second session for the same range. The review then found two sessions for one range and stopped. The carry keeps the repository part of the name, names the range from the oldest commit to the newest, and stores the range and the base commit the way tuicr stores them. A range of more than one commit carries now, because the captured range is compared as a set of commits. Change-Id: Icfe9e542dce76fcaec12d12c00ab2a051554db18
A store can hold two sessions for one range: a carried session and the session that tuicr wrote. The reader refused to choose between them, so a review stopped and every retry stopped the same way. The reader continues with the session that the index recorded last, because that is the session that tuicr reopens. A selector still names an exact session. The file review store follows the same rule. Change-Id: I27b447cc8186590e99f54e9dc4a98cefe531cad9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.